maedhroz commented on code in PR #2898:
URL: https://github.com/apache/cassandra/pull/2898#discussion_r1394747219


##########
test/distributed/org/apache/cassandra/distributed/test/RepairErrorsTest.java:
##########
@@ -92,8 +92,7 @@ public void testRemoteSyncFailure() throws Exception
         try (Cluster cluster = init(Cluster.build(3)
                                            .withConfig(config -> 
config.with(GOSSIP)
                                                                        
.with(NETWORK)
-                                                                       
.set("disk_failure_policy", "stop")
-                                                                       
.set("disk_access_mode", "mmap_index_only"))

Review Comment:
   Even though the default has now changed, this continues to be a necessary 
condition for the test, and leaving it place to document that seems like a good 
idea. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to