michaelsembwever commented on PR #2563: URL: https://github.com/apache/cassandra/pull/2563#issuecomment-1817766968
@shyla226 this is looking good. i have further questions about tightening up the messages, and avoiding us having to edit hardcoded numbers. these are best expressed in the following suggested patch. does it make sense ? are you willing to squash it into your work ? https://github.com/apache/cassandra/commit/90974e4222fab9beb0e5abea40503a13c4c3985f (if you agree, it would need to be re-applied to each of the modified files) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
