mike-tr-adamson commented on code in PR #2916:
URL: https://github.com/apache/cassandra/pull/2916#discussion_r1399185834


##########
test/unit/org/apache/cassandra/index/sai/utils/AbstractPrimaryKeyTester.java:
##########
@@ -146,7 +146,7 @@ else if (expected < 0)
     protected DecoratedKey makeKey(TableMetadata table, Object...partitionKeys)
     {
         ByteBuffer key;
-        if (TypeUtil.isComposite(table.partitionKeyType))
+        if (table.partitionKeyType instanceof CompositeType)

Review Comment:
   That is my understanding. `ReversedType` is only used for clustering keys 
that are ordered `DESC`. I have looked for other usages and can't find any.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to