maedhroz commented on code in PR #2916:
URL: https://github.com/apache/cassandra/pull/2916#discussion_r1402600839
##########
src/java/org/apache/cassandra/index/sai/metrics/ColumnQueryMetrics.java:
##########
@@ -21,15 +21,15 @@
import com.codahale.metrics.Meter;
import com.codahale.metrics.Timer;
-import org.apache.cassandra.index.sai.IndexContext;
+import org.apache.cassandra.index.sai.StorageAttachedIndex;
import static org.apache.cassandra.metrics.CassandraMetricsRegistry.Metrics;
public abstract class ColumnQueryMetrics extends AbstractMetrics
{
- protected ColumnQueryMetrics(IndexContext indexContext)
+ protected ColumnQueryMetrics(StorageAttachedIndex index)
Review Comment:
Here and in `IndexMetrics` would it make more sense to just use
`IndexIdentifier` instead of having to pass the whole `StorageAttachedIndex`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
