mike-tr-adamson commented on code in PR #2916:
URL: https://github.com/apache/cassandra/pull/2916#discussion_r1403249208
##########
src/java/org/apache/cassandra/index/sai/disk/v1/MemtableIndexWriter.java:
##########
@@ -55,19 +55,25 @@ public class MemtableIndexWriter implements
PerColumnIndexWriter
private static final Logger logger =
LoggerFactory.getLogger(MemtableIndexWriter.class);
private final IndexDescriptor indexDescriptor;
- private final IndexContext indexContext;
+ private final IndexTermType indexTermType;
+ private final IndexIdentifier indexIdentifier;
+ private final IndexMetrics indexMetrics;
Review Comment:
My intent here had always been to only pass references to the classes that
were being used. Passing a `StorageAttachedIndex` makes sense in the case of
`IndexViewManager` because the index is needed to create the `SSTableIndex`. In
this case we don't need an index.
EDIT: The rebase on top of current changes means that we now need the index
in this class so I've changed to just using the index and have removed the
other references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
