yifan-c commented on code in PR #80:
URL: https://github.com/apache/cassandra-sidecar/pull/80#discussion_r1406329450
##########
adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/CassandraAdapter.java:
##########
@@ -96,12 +96,23 @@ public NodeSettings nodeSettings()
return null;
}
- Row oneResult = activeSession.execute("select release_version,
partitioner from system.local")
+ Row oneResult = activeSession.execute("select release_version, "
Review Comment:
nit: create constants for the column names, since there are more fields
queried.
##########
common/src/main/java/org/apache/cassandra/sidecar/common/NodeSettings.java:
##########
@@ -103,15 +135,162 @@ public boolean equals(Object other)
}
NodeSettings that = (NodeSettings) other;
return Objects.equals(this.releaseVersion, that.releaseVersion)
- && Objects.equals(this.partitioner, that.partitioner)
- && Objects.equals(this.sidecar, that.sidecar);
+ && Objects.equals(this.partitioner, that.partitioner)
+ && Objects.equals(this.sidecar, that.sidecar)
+ && Objects.equals(this.datacenter, that.datacenter)
+ && Objects.equals(this.rpcAddress, that.rpcAddress)
+ && Objects.equals(this.rpcPort, that.rpcPort)
+ && Objects.equals(this.tokens, that.tokens)
+ ;
Review Comment:
accidental line break?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
