yifan-c commented on code in PR #79:
URL: https://github.com/apache/cassandra-sidecar/pull/79#discussion_r1406390557
##########
src/main/java/org/apache/cassandra/sidecar/config/yaml/SslConfigurationImpl.java:
##########
@@ -227,8 +261,29 @@ public Builder handshakeTimeoutInSeconds(long
handshakeTimeoutInSeconds)
*/
public Builder clientAuth(String clientAuth)
{
- this.clientAuth = clientAuth;
- return this;
+ return update(b -> b.clientAuth = clientAuth);
+ }
+
+ /**
+ * Sets the {@code cipherSuites} and returns a reference to this
Builder enabling method chaining.
+ *
+ * @param cipherSuites the {@code cipherSuites} to set
+ * @return a reference to this Builder
+ */
+ public Builder cipherSuites(List<String> cipherSuites)
+ {
+ return update(b -> b.cipherSuites = cipherSuites);
Review Comment:
nit: copy the list instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
