maedhroz commented on code in PR #2932:
URL: https://github.com/apache/cassandra/pull/2932#discussion_r1406575124
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java:
##########
@@ -390,10 +390,15 @@ public Callable<?> getPreJoinTask(boolean hadBootstrap)
public Callable<?> getTruncateTask(long truncatedAt)
{
/*
- * index files will be removed as part of base sstable lifecycle in
- * {@link LogTransaction#delete(java.io.File)} asynchronously.
+ * index files will be removed as part of base sstable lifecycle in
{@link LogTransaction#delete(java.io.File)}
+ * asynchronously, but we need to mark the index queryable because if
the truncation is during the initial
+ * build of the index it won't get marked queryable by the build.
Review Comment:
If the index is currently marked as non-queryable, and we truncate, is this
safe because truncation will remove all the on-disk artifacts (or lack of those
artifacts) that made the index non-queryable in the first place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
