ifesdjeen commented on code in PR #23:
URL: https://github.com/apache/cassandra-harry/pull/23#discussion_r1414602598
##########
harry-core/src/harry/dsl/HistoryBuilder.java:
##########
@@ -361,32 +350,22 @@ public HistoryBuilder finish()
void addSteps(List<Step> steps)
{
- List<ReplayingVisitor.Batch> batches = new ArrayList<>();
- Counter m = new Counter();
+ List<ReplayingVisitor.Operation> operations = new ArrayList<>();
Counter opId = new Counter();
for (Step step : steps)
{
- batches.add(step.toBatch(pd, lts, m.get(),
opId::getAndIncrement));
Review Comment:
yes! Is a small simplificaiton, but makes things much simpler when working
on history builder, less indirection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
