maedhroz commented on code in PR #2935:
URL: https://github.com/apache/cassandra/pull/2935#discussion_r1414926732
##########
src/java/org/apache/cassandra/index/sai/disk/v1/MemtableIndexWriter.java:
##########
@@ -89,7 +89,12 @@ public void addRow(PrimaryKey key, Row row, long
sstableRowId)
@Override
public void abort(Throwable cause)
{
- logger.warn(indexIdentifier.logMessage("Aborting index memtable flush
for {}..."), indexDescriptor.sstableDescriptor, cause);
+ if (cause == null)
+ // This commonly occurs when a Memtable has no rows to flush, and
is harmless:
+ logger.debug(indexIdentifier.logMessage("Aborting index memtable
flush for {}..."), indexDescriptor.sstableDescriptor);
+ else
+ logger.warn(indexIdentifier.logMessage("Aborting index memtable
flush for {}..."), indexDescriptor.sstableDescriptor, cause);
+
Review Comment:
@mike-tr-adamson @adelapena This makes some of the tests noisier, given they
don't write tons of data or write data to all columns in all cases...so I just
fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]