blambov commented on code in PR #2896:
URL: https://github.com/apache/cassandra/pull/2896#discussion_r1415625446
##########
test/unit/org/apache/cassandra/db/SchemaCQLHelperTest.java:
##########
@@ -444,13 +446,17 @@ public void testSnapshot() throws Throwable
containsString("ALTER TABLE " + keyspace() + "." +
tableName + " DROP reg3 USING TIMESTAMP 10000;"),
containsString("ALTER TABLE " + keyspace() + "." +
tableName + " ADD reg3 int;")));
- assertThat(schema, containsString("CREATE INDEX IF NOT EXISTS " +
tableName + "_reg2_idx ON " + keyspace() + '.' + tableName + " (reg2);"));
+ final boolean isIndexLegacy =
DatabaseDescriptor.getDefaultSecondaryIndex().equals(CassandraIndex.NAME);
Review Comment:
Created `Util.assumeLegacySecondaryIndex()` to replace most of the
repetition.
It doesn't change this particular line, though. Let me know if you insist on
that being placed in `Util` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
