dcapwell commented on code in PR #2963:
URL: https://github.com/apache/cassandra/pull/2963#discussion_r1416187642
##########
src/java/org/apache/cassandra/db/compaction/CompactionIterator.java:
##########
@@ -805,7 +804,7 @@ protected Row applyToRow(Row row)
// When commands end up being sliced by compaction we need this to
discard tombstones and slices
// without enough information to run the rest of the cleanup logic
- if (durableBefore.min(txnId) == Universal)
+ if (durableBefore.isUniversal(txnId))
Review Comment:
so rather than `Universal` we now use `UniversalOrInvalidated`?
##########
src/java/org/apache/cassandra/db/compaction/CompactionIterator.java:
##########
@@ -805,7 +804,7 @@ protected Row applyToRow(Row row)
// When commands end up being sliced by compaction we need this to
discard tombstones and slices
// without enough information to run the rest of the cleanup logic
- if (durableBefore.min(txnId) == Universal)
+ if (durableBefore.isUniversal(txnId))
Review Comment:
shouldn't this be `UniversalOrInvalidated || Universal`? maybe ask Benedict
for clarity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
