aweisberg commented on code in PR #77:
URL: https://github.com/apache/cassandra-accord/pull/77#discussion_r1416355673
##########
accord-core/src/main/java/accord/local/DurableBefore.java:
##########
@@ -191,6 +191,11 @@ public Durability get(TxnId txnId, RoutingKey participant)
return entry == null ? NotDurable : entry.get(txnId);
}
+ public boolean isUniversal(TxnId txnId)
+ {
+ return min(txnId) == UniversalOrInvalidated;
Review Comment:
@belliottsmith should this be `UniversalOrInvalidated` or both `Universal`
and `UniversalOrInvalidated`. We use this from the accord compaction purger
code to determine if something is universally durable and can be dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
