maedhroz commented on code in PR #24: URL: https://github.com/apache/cassandra-harry/pull/24#discussion_r1418072590
########## harry-integration/test/harry/dsl/HistoryBuilderIntegrationTest.java: ########## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package harry.dsl; + +import java.util.Random; +import java.util.function.LongSupplier; +import java.util.function.Supplier; + +import org.junit.Test; + +import harry.checker.ModelChecker; +import harry.core.Configuration; +import harry.core.Run; +import harry.ddl.SchemaGenerators; +import harry.ddl.SchemaSpec; +import harry.generators.JdkRandomEntropySource; +import harry.model.Model; +import harry.model.ModelTestBase; +import harry.model.QuiescentChecker; +import harry.operations.Query; +import harry.reconciler.Reconciler; +import harry.visitors.ReplayingVisitor; + +public class HistoryBuilderIntegrationTest extends ModelTestBase +{ + private final long seed = 1L; + private final int STEPS_PER_ITERATION = 1_000; + private final int MAX_PARTITIONS = 100; + + protected Configuration.ModelConfiguration modelConfiguration() + { + return new Configuration.QuiescentCheckerConfig(); + } + + public Configuration.ConfigurationBuilder configuration(long seed, SchemaSpec schema) + { + return super.configuration(seed, schema) + .setPartitionDescriptorSelector(new Configuration.DefaultPDSelectorConfiguration(2, 2)) + .setClusteringDescriptorSelector((builder) -> builder.setOperationsPerLtsDistribution(new Configuration.ConstantDistributionConfig(100_000))); + } + + @Test + public void simpleDSLTest() throws Throwable + { + Supplier<SchemaSpec> supplier = SchemaGenerators.progression(SchemaGenerators.DEFAULT_SWITCH_AFTER); + for (int i = 0; i < SchemaGenerators.DEFAULT_RUNS; i++) + { + SchemaSpec schema = supplier.get(); + Configuration config = configuration(i, schema).build(); + + Run run = config.createRun(); + beforeEach(); + run.sut.schemaChange(schema.compile().cql()); + + ModelChecker<SingleOperationBuilder> modelChecker = new ModelChecker<>(); + JdkRandomEntropySource entropySource = new JdkRandomEntropySource(new Random(seed)); + + LongSupplier[] valueGenerators = new LongSupplier[run.schemaSpec.regularColumns.size()]; + for (int j = 0; j < valueGenerators.length; j++) + { + valueGenerators[j] = new ValueDescriptorIndexGenerator(run.schemaSpec.regularColumns.get(j), + run.rng) + .toSupplier(entropySource.derive(), 20, 0.2f); + } + + int maxPartitionSize = 100; + modelChecker.init(new HistoryBuilder(seed, maxPartitionSize, 10, schema)) + .step((history) -> { + return history.insert(); + }) + .step((history) -> { + return history.insert(entropySource.nextInt(maxPartitionSize)); + }) + .step((history) -> { + int row = entropySource.nextInt(maxPartitionSize); + long[] vds = new long[valueGenerators.length]; + for (int j = 0; j < valueGenerators.length; j++) + vds[j] = valueGenerators[j].getAsLong(); + + return history.insert(row, vds); + }) + .step((history) -> { + return history.deleteRow(); + }) + .step((history) -> { + return history.deleteRow(entropySource.nextInt(maxPartitionSize)); + }) + .step(SingleOperationBuilder::deletePartition) + .step(SingleOperationBuilder::deleteColumns) + .step(SingleOperationBuilder::deleteRowSlice) + .step((history) -> { + return history.deleteRowRange(); + }) + .step((history) -> { + return history.deleteRowRange(entropySource.nextInt(maxPartitionSize), + entropySource.nextInt(maxPartitionSize), + entropySource.nextBoolean(), + entropySource.nextBoolean()); + }) + .step((history) -> history instanceof HistoryBuilder, + (history) -> ((HistoryBuilder) history).beginBatch()) + .step((history) -> (history instanceof BatchVisitBuilder) && ((BatchVisitBuilder) history).size() > 1, + (history) -> ((BatchVisitBuilder) history).endBatch()) + .exitCondition((history) -> { + if (!(history instanceof HistoryBuilder)) + return false; + + HistoryBuilder historyBuilder = (HistoryBuilder) history; + ReplayingVisitor visitor = historyBuilder.visitor(run.tracker, run.sut); + visitor.replayAll(); + + if (historyBuilder.presetSelector.pds().size() < MAX_PARTITIONS) + return false; + + Model model = historyBuilder.checker(run.tracker, sut); + + for (Long pd : historyBuilder.presetSelector.pds()) + model.validate(Query.selectPartition(run.schemaSpec, pd,false)); + + return true; + }) + .run(STEPS_PER_ITERATION, seed); Review Comment: So I'll summarize what I think is going on here, and then my review should be complete... We create a `ModelChecker` with single-operation steps to... 1.) Record a series of operations against the model using a `HistoryBuilder` as the state container. 2.) Replay them all against the SUT. 3.) Validate all the partitions we visited. There are some details I'm not clear on, though. It looks like `ModelChecker#run()` executes individual steps, and each step execution adds data to the `HistoryBuilder` log. Then when we check the exit condition, we actually replay the operations to the SUT from the beginning up to the last visited LTS and validate the model. Am I one the right track? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
