smiklosovic commented on code in PR #2971:
URL: https://github.com/apache/cassandra/pull/2971#discussion_r1419155901
##########
build.xml:
##########
@@ -30,6 +30,7 @@
<property environment="env"/>
<property file="build.properties" />
<property file="build.properties.default" />
+ <property file="${user.home}/.ant/build.properties"/>
Review Comment:
Jacek has worktrees per branch, I have a worktree per logical branch (I have
cassandra-{3.0,3.11,4.0,4.1,5.0,trunk} directories and then I just switch
branches for that particular branch inside). `build.properties` are
`.gitignor`-ed so that means that these properties would be "lost" in Jacek's
case, but not mine. We also do not want to hardcode paths outside of repo
except of some dirs in `tmp.dir` nor anywhere in user's home. Somebody is OK
with this, somebody is not ... to each their own. This one solves it globally
for everybody how they please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
