maedhroz commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1420774359


##########
src/java/org/apache/cassandra/service/reads/thresholds/CoordinatorWarnings.java:
##########
@@ -147,14 +152,14 @@ private static void clearState()
     @FunctionalInterface
     private interface ToString
     {
-        String apply(int count, long value, String cql);
+        String apply(ImmutableSet<InetAddressAndPort> nodes, long value, 
String cql);

Review Comment:
   Possibly, although for LCS, the main source of this kind of problem, 
compaction will not be a fix. Also, when this problem exists, it will likely 
exist on all replicas (or almost all replicas). This guardrail, in many ways, 
is a pre-prod guardrail. If you hit it, it usually means you've gone very wrong 
at the data modeling stage, and there really isn't an easy fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to