smiklosovic commented on code in PR #2977:
URL: https://github.com/apache/cassandra/pull/2977#discussion_r1423381459


##########
src/java/org/apache/cassandra/utils/FBUtilities.java:
##########
@@ -939,6 +939,33 @@ public static String prettyPrintMemory(long size, String 
separator)
                                  UNIT_PREFIXES.charAt(UNIT_PREFIXES_BASE + 
prefixIndex));
     }
 
+    /**
+     * Convert the given size in bytes to a human-readable value using binary 
(i.e. 2^10-based) modifiers
+     * with only three significant digits.
+     * For example, "4.96 KiB", "48.8 KiB", "477 MiB", "0.422 KiB", "0.000 
KiB".
+     * @param size      Number to convert.
+     */
+    public static String prettyPrintMemoryShort(long size)

Review Comment:
   can you just walk us through this method conceptually? It is a little bit 
hard to follow to be honest.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to