mike-tr-adamson commented on code in PR #2986:
URL: https://github.com/apache/cassandra/pull/2986#discussion_r1424049742
##########
src/java/org/apache/cassandra/index/sai/plan/StorageAttachedIndexSearcher.java:
##########
@@ -153,11 +153,6 @@ private ResultRetriever(QueryController queryController,
@Override
public UnfilteredRowIterator computeNext()
{
- // IMPORTANT: The correctness of the entire query pipeline relies
on the fact that we consume a token
- // and materialize its keys before moving on to the next token in
the flow. This sequence must not be broken
- // with toList() or similar. (Both the union and intersection flow
constructs, to avoid excessive object
- // allocation, reuse their token mergers as they process
individual positions on the ring.)
-
Review Comment:
This comment was redundant because it applied to different implementation of
SAI that was using reactive flows and the sequencing of calls was very
important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
