Mmuzaf commented on code in PR #2556: URL: https://github.com/apache/cassandra/pull/2556#discussion_r1425350474
########## src/java/org/apache/cassandra/index/sai/disk/PrimaryKeyMapIterator.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.index.sai.disk; + +import java.io.IOException; + +import org.apache.cassandra.db.PartitionPosition; +import org.apache.cassandra.dht.AbstractBounds; +import org.apache.cassandra.dht.Token; +import org.apache.cassandra.index.sai.SSTableContext; +import org.apache.cassandra.index.sai.iterators.KeyRangeIterator; +import org.apache.cassandra.index.sai.utils.PrimaryKey; + +/** + * Iterates keys in the {@link PrimaryKeyMap} of a SSTable. + * Iterating keys in the primary key map is faster than reading them from the SSTable data component + * because we don't deserialize all the other columns except the primary key columns. + * The primary key map components are also likely much smaller than the whole SSTable data component. + * <p> + * The keys are returned in token-clustering order. + */ +public final class PrimaryKeyMapIterator extends KeyRangeIterator Review Comment: The iterator looks very similar to this one, do we still need to keep it? ``` private SSTableRowIdKeyRangeIterator(PrimaryKey min, PrimaryKey max, long count, PrimaryKeyMap primaryKeyMap, QueryContext queryContext, PostingList postingList) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
