Maxwell-Guo commented on code in PR #2983: URL: https://github.com/apache/cassandra/pull/2983#discussion_r1429041586
########## test/unit/org/apache/cassandra/service/StartupChecksTest.java: ########## @@ -17,33 +17,45 @@ */ package org.apache.cassandra.service; -import java.io.IOException; -import java.nio.file.Files; -import java.nio.file.Path; -import java.nio.file.Paths; -import java.time.Instant; -import java.util.List; - -import org.apache.cassandra.config.StartupChecksOptions; -import org.apache.cassandra.io.util.File; -import org.junit.*; - +import com.vdurmont.semver4j.Semver; import org.apache.cassandra.SchemaLoader; +import org.apache.cassandra.config.Config.DiskAccessMode; import org.apache.cassandra.config.DatabaseDescriptor; -import org.apache.cassandra.schema.SchemaConstants; -import org.apache.cassandra.db.*; +import org.apache.cassandra.config.StartupChecksOptions; +import org.apache.cassandra.db.ColumnFamilyStore; +import org.apache.cassandra.db.Directories; +import org.apache.cassandra.db.Keyspace; import org.apache.cassandra.exceptions.StartupException; +import org.apache.cassandra.io.filesystem.ForwardingFileSystem; +import org.apache.cassandra.io.filesystem.ForwardingFileSystemProvider; +import org.apache.cassandra.io.filesystem.ForwardingPath; +import org.apache.cassandra.io.util.File; +import org.apache.cassandra.schema.SchemaConstants; import org.apache.cassandra.service.DataResurrectionCheck.Heartbeat; import org.apache.cassandra.utils.Clock; +import org.apache.cassandra.utils.FBUtilities; +import org.junit.*; + +import java.io.IOException; +import java.nio.file.*; Review Comment: I would expand these imports ########## test/unit/org/apache/cassandra/service/StartupChecksTest.java: ########## @@ -17,33 +17,45 @@ */ package org.apache.cassandra.service; -import java.io.IOException; -import java.nio.file.Files; -import java.nio.file.Path; -import java.nio.file.Paths; -import java.time.Instant; -import java.util.List; - -import org.apache.cassandra.config.StartupChecksOptions; -import org.apache.cassandra.io.util.File; -import org.junit.*; - +import com.vdurmont.semver4j.Semver; import org.apache.cassandra.SchemaLoader; +import org.apache.cassandra.config.Config.DiskAccessMode; import org.apache.cassandra.config.DatabaseDescriptor; -import org.apache.cassandra.schema.SchemaConstants; -import org.apache.cassandra.db.*; +import org.apache.cassandra.config.StartupChecksOptions; +import org.apache.cassandra.db.ColumnFamilyStore; +import org.apache.cassandra.db.Directories; +import org.apache.cassandra.db.Keyspace; import org.apache.cassandra.exceptions.StartupException; +import org.apache.cassandra.io.filesystem.ForwardingFileSystem; +import org.apache.cassandra.io.filesystem.ForwardingFileSystemProvider; +import org.apache.cassandra.io.filesystem.ForwardingPath; +import org.apache.cassandra.io.util.File; +import org.apache.cassandra.schema.SchemaConstants; import org.apache.cassandra.service.DataResurrectionCheck.Heartbeat; import org.apache.cassandra.utils.Clock; +import org.apache.cassandra.utils.FBUtilities; +import org.junit.*; Review Comment: I would expand these imports ########## test/unit/org/apache/cassandra/utils/FBUtilitiesTest.java: ########## @@ -18,39 +18,30 @@ package org.apache.cassandra.utils; -import java.io.IOException; -import java.net.InetAddress; -import java.nio.ByteBuffer; -import java.nio.charset.CharacterCodingException; -import java.nio.charset.StandardCharsets; -import java.util.Arrays; -import java.util.Map; -import java.util.Optional; -import java.util.Random; -import java.util.TreeMap; -import java.util.ArrayList; -import java.util.List; -import java.util.concurrent.CountDownLatch; -import java.util.concurrent.ExecutionException; -import java.util.concurrent.ExecutorService; -import java.util.concurrent.Executors; -import java.util.concurrent.Future; -import java.util.concurrent.TimeUnit; - import com.google.common.primitives.Ints; - +import com.vdurmont.semver4j.Semver; +import org.apache.cassandra.config.Config; +import org.apache.cassandra.config.DatabaseDescriptor; +import org.apache.cassandra.db.marshal.AbstractType; +import org.apache.cassandra.db.marshal.Int32Type; +import org.apache.cassandra.db.marshal.ListType; +import org.apache.cassandra.db.marshal.UUIDType; +import org.apache.cassandra.dht.*; import org.junit.Assert; +import org.junit.Assume; import org.junit.Test; - import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import org.apache.cassandra.db.marshal.*; -import org.apache.cassandra.dht.*; - -import org.apache.cassandra.config.Config; -import org.apache.cassandra.config.DatabaseDescriptor; +import java.io.IOException; +import java.net.InetAddress; +import java.nio.ByteBuffer; +import java.nio.charset.CharacterCodingException; +import java.nio.charset.StandardCharsets; +import java.util.*; Review Comment: I would expand these imports ########## test/unit/org/apache/cassandra/service/StartupChecksTest.java: ########## @@ -17,33 +17,45 @@ */ package org.apache.cassandra.service; -import java.io.IOException; -import java.nio.file.Files; -import java.nio.file.Path; -import java.nio.file.Paths; -import java.time.Instant; -import java.util.List; - -import org.apache.cassandra.config.StartupChecksOptions; -import org.apache.cassandra.io.util.File; -import org.junit.*; - +import com.vdurmont.semver4j.Semver; import org.apache.cassandra.SchemaLoader; +import org.apache.cassandra.config.Config.DiskAccessMode; import org.apache.cassandra.config.DatabaseDescriptor; -import org.apache.cassandra.schema.SchemaConstants; -import org.apache.cassandra.db.*; +import org.apache.cassandra.config.StartupChecksOptions; +import org.apache.cassandra.db.ColumnFamilyStore; +import org.apache.cassandra.db.Directories; +import org.apache.cassandra.db.Keyspace; import org.apache.cassandra.exceptions.StartupException; +import org.apache.cassandra.io.filesystem.ForwardingFileSystem; +import org.apache.cassandra.io.filesystem.ForwardingFileSystemProvider; +import org.apache.cassandra.io.filesystem.ForwardingPath; +import org.apache.cassandra.io.util.File; +import org.apache.cassandra.schema.SchemaConstants; import org.apache.cassandra.service.DataResurrectionCheck.Heartbeat; import org.apache.cassandra.utils.Clock; +import org.apache.cassandra.utils.FBUtilities; +import org.junit.*; + +import java.io.IOException; +import java.nio.file.*; +import java.nio.file.spi.FileSystemProvider; +import java.time.Instant; +import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.Callable; +import java.util.stream.Collectors; import static java.util.Collections.singletonList; import static org.apache.cassandra.config.CassandraRelevantProperties.TEST_INVALID_LEGACY_SSTABLE_ROOT; import static org.apache.cassandra.io.util.FileUtils.createTempFile; import static org.apache.cassandra.service.DataResurrectionCheck.HEARTBEAT_FILE_CONFIG_PROPERTY; import static org.apache.cassandra.service.StartupChecks.StartupCheckType.check_data_resurrection; -import static org.junit.Assert.assertNotEquals; -import static org.junit.Assert.assertTrue; -import static org.junit.Assert.fail; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatExceptionOfType; +import static org.junit.Assert.*; Review Comment: I would expand these imports -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
