Runtian commented on code in PR #2993:
URL: https://github.com/apache/cassandra/pull/2993#discussion_r1429219489
##########
test/unit/org/apache/cassandra/gms/GossiperTest.java:
##########
@@ -188,7 +188,7 @@ public void
testAssassinatedNodeWillNotContributeToVersionCalculation() throws E
Gossiper.instance.assassinateEndpoint("127.0.0.4");
assertTrue(Gossiper.instance.endpointStateMap.containsKey(InetAddressAndPort.getByName("127.0.0.4")));
- assertNull(Gossiper.instance.upgradeFromVersionSupplier.get().value());
+
assertTrue(Gossiper.instance.upgradeFromVersionSupplier.get().canMemoize());
Review Comment:
Just want to make sure the supplier is getting value which can memoize. The
null value is the expected memoized value. So they are basically same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
