smiklosovic commented on code in PR #2334:
URL: https://github.com/apache/cassandra/pull/2334#discussion_r1431593168
##########
src/java/org/apache/cassandra/io/sstable/indexsummary/IndexSummaryManager.java:
##########
@@ -296,6 +318,7 @@ public void shutdownAndWait(long timeout, TimeUnit unit)
throws InterruptedExcep
future.cancel(false);
future = null;
}
+ shutdownTasks.forEach(Runnable::run);
Review Comment:
what if `Runnable#run` throws? Then it will never get to
ExecutorUtils.shutdownAndWait on the next line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
