Maxwell-Guo commented on code in PR #2995:
URL: https://github.com/apache/cassandra/pull/2995#discussion_r1432531567
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -616,10 +619,9 @@ public enum CassandraRelevantProperties
USE_NIX_RECURSIVE_DELETE("cassandra.use_nix_recursive_delete"),
/** Gossiper compute expiration timeout. Default value 3 days. */
VERY_LONG_TIME_MS("cassandra.very_long_time_ms", "259200000"),
-
WAIT_FOR_TRACING_EVENTS_TIMEOUT_SECS("cassandra.wait_for_tracing_events_timeout_secs",
"0"),
+
WAIT_FOR_TRACING_EVENTS_TIMEOUT_SECS("cassandra.wait_for_tracing_events_timeout_secs",
"0")
Review Comment:
";" should not start a new line
##########
src/java/org/apache/cassandra/utils/FBUtilities.java:
##########
@@ -1136,6 +1150,41 @@ public static void exec(ProcessBuilder pb) throws
IOException
}
}
+ public static String exec(Map<String, String> env, Duration timeout, int
outBufSize, int errBufSize, String... cmd) throws IOException,
TimeoutException, InterruptedException
Review Comment:
trunk 's exec method is different from 5.0
[here](https://github.com/apache/cassandra/pull/2983/files)
no description of the function and lack of some logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
