jacek-lewandowski commented on code in PR #2984:
URL: https://github.com/apache/cassandra/pull/2984#discussion_r1433000506
##########
test/distributed/org/apache/cassandra/distributed/test/MigrationCoordinatorTest.java:
##########
@@ -21,32 +21,43 @@
import java.net.InetAddress;
import java.util.UUID;
+import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.apache.cassandra.distributed.Cluster;
import org.apache.cassandra.distributed.api.IInstanceConfig;
import org.apache.cassandra.distributed.api.TokenSupplier;
import org.apache.cassandra.distributed.shared.NetworkTopology;
+import org.apache.cassandra.distributed.shared.WithProperties;
import org.apache.cassandra.schema.Schema;
-import static
org.apache.cassandra.config.CassandraRelevantProperties.CONSISTENT_RANGE_MOVEMENT;
+import static
org.apache.cassandra.config.CassandraRelevantProperties.BROADCAST_INTERVAL_MS;
import static
org.apache.cassandra.config.CassandraRelevantProperties.IGNORED_SCHEMA_CHECK_ENDPOINTS;
import static
org.apache.cassandra.config.CassandraRelevantProperties.IGNORED_SCHEMA_CHECK_VERSIONS;
import static
org.apache.cassandra.config.CassandraRelevantProperties.REPLACE_ADDRESS;
+import static
org.apache.cassandra.config.CassandraRelevantProperties.RING_DELAY;
import static org.apache.cassandra.distributed.api.Feature.GOSSIP;
import static org.apache.cassandra.distributed.api.Feature.NETWORK;
public class MigrationCoordinatorTest extends TestBaseImpl
{
+ private static WithProperties withProperties;
Review Comment:
I can imagine more user-friendly api for `WithProperties`... but it would be
good to use it or implement something in common pre/post test hooks, separate
topic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
