maedhroz commented on code in PR #2961:
URL: https://github.com/apache/cassandra/pull/2961#discussion_r1434444165
##########
src/java/org/apache/cassandra/index/sai/plan/QueryController.java:
##########
@@ -184,6 +188,8 @@ public KeyRangeIterator.Builder
getIndexQueryResults(Collection<Expression> expr
QueryViewBuilder.QueryView queryView = queryViewBuilder.build();
+ maybeTriggerGuardrails(queryView);
Review Comment:
So I think the reason you're seeing LEAKs in the new tests is that this
needs to happen inside the `try` below. If we don't do that, we won't release
the `SSTableIndex`es when we hit the failure threshold.
(Just verified locally on my machine that your tests are clean w/ this
change.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
