smiklosovic commented on code in PR #2842:
URL: https://github.com/apache/cassandra/pull/2842#discussion_r1440338534
##########
src/java/org/apache/cassandra/config/CassandraRelevantProperties.java:
##########
@@ -567,7 +567,7 @@ public enum CassandraRelevantProperties
* can be also done manually for that particular case: {@code
flush(SchemaConstants.SCHEMA_KEYSPACE_NAME);}. */
TEST_FLUSH_LOCAL_SCHEMA_CHANGES("cassandra.test.flush_local_schema_changes",
"true"),
TEST_HARRY_SWITCH_AFTER("cassandra.test.harry.progression.switch-after",
"1"),
- TEST_IGNORE_SIGAR("cassandra.test.ignore_sigar"),
Review Comment:
@jacek-lewandowski
in `SigarLibrary#warnIfRunningInDegradedMode` as well as in
`SimulationRunner#beforeAll`.
Honestly, I don't see any reason for its usage in
`warnIfRunningInDegradedMode`. If you check that logic, it does not make sense.
Imagine that all checks pass. So the warning will be logged when
`TEST_IGNORE_SIGAR` is set to true? Why would one want that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
