smiklosovic commented on code in PR #2842:
URL: https://github.com/apache/cassandra/pull/2842#discussion_r1440406111
##########
src/java/org/apache/cassandra/service/StartupChecks.java:
##########
@@ -417,14 +417,26 @@ public void execute(StartupChecksOptions options) throws
StartupException
}
};
- public static final StartupCheck initSigarLibrary = new StartupCheck()
+ public static final StartupCheck checkProcessEnvironment = new
StartupCheck()
{
@Override
public void execute(StartupChecksOptions options)
{
if (options.isDisabled(getStartupCheckType()))
return;
- SigarLibrary.instance.warnIfRunningInDegradedMode();
+
+ Optional<String> degradations = new SystemInfo().isDegraded();
+
+ if (degradations.isPresent())
+ {
+ String message = "Cassandra server running in degraded mode. "
+ degradations.get();
+ if
(CassandraRelevantProperties.TEST_IGNORE_PROCESS_ENVIRONMENT_CHECK.getBoolean())
+ logger.warn(message);
+ else
+ logger.info(message);
+ }
+ else
+ logger.info("Checked OS settings and found them configured for
optimal performance.");
Review Comment:
@jacek-lewandowski
Then we need to remove all these checks as well and find new place for them
with whole machinery around that.
checkJemalloc
checkLz4Native
checkJMXPorts
checkJMXProperties
inspectJvmOptions
checkMaxMapCount
checkReadAheadKbSetting
Why not to just do it as proposed here and then we can elaborate on that in
a different ticket?
Keep in mind that we are rewriting the check, we are not implementing a new
one. This will save us couple MBs from the tarball too.
I understand your point but extracting this from startup checks is not the
objective here at the moment ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
