belliottsmith commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1443280250
##########
accord-core/src/main/java/accord/primitives/AbstractRanges.java:
##########
@@ -56,7 +56,10 @@ public int indexOf(RoutableKey key)
@Override
public int indexOf(Range find)
Review Comment:
I would prefer to remove `indexOf` from `Routables` and introduce a new
`indexOf` method only for `RoutableKey` types (e.g. RoutingKeys and Keys). We
shouldn't really _have_ an `indexOf` method that accepts a `Range` for
`AbstractRanges` as its poorly defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
