maedhroz commented on code in PR #3018:
URL: https://github.com/apache/cassandra/pull/3018#discussion_r1443508639
##########
src/java/org/apache/cassandra/transport/ExceptionHandlers.java:
##########
@@ -133,6 +136,15 @@ else if (Throwables.anyCauseMatches(cause, t -> t
instanceof Errors.NativeIoExce
ClientMetrics.instance.markUnknownException();
logger.trace("Native exception in client networking", cause);
}
+ else if (Throwables.anyCauseMatches(cause, t -> t instanceof
SSLHandshakeException))
+ {
+ ClientMetrics.instance.markSSLHandshakeException();
+ NoSpamLogger.log(logger, NoSpamLogger.Level.WARN, 1,
TimeUnit.MINUTES, "SSLHandshakeException in client networking with peer {} {}",
clientAddress, cause.getMessage());
+ }
+ else if (Throwables.anyCauseMatches(cause, t -> t instanceof
SSLException))
+ {
+ NoSpamLogger.log(logger, NoSpamLogger.Level.WARN, 1,
TimeUnit.MINUTES, "SSLException in client networking with peer {} {}",
clientAddress, cause.getMessage());
+ }
Review Comment:
The only thing that worries me a little bit here is what happens when we
have overloads, protocol exceptions, and SSL problems all occurring at the same
time. It's not that expensive to create a new logger to wrap, specifically for
SSL exceptions. Any objection to doing that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
