dcapwell commented on code in PR #65:
URL: https://github.com/apache/cassandra-accord/pull/65#discussion_r1446674622
##########
accord-core/src/main/java/accord/coordinate/TxnExecute.java:
##########
@@ -74,8 +75,9 @@ private TxnExecute(Node node, TxnId txnId, Txn txn,
FullRoute<?> route, Particip
}
@Override
- protected void start(Set<Id> readSet)
+ protected void start(Iterable<Id> to)
{
+ Set<Id> readSet = Sets.newHashSet(to);
Review Comment:
ill make the change but I wonder if its not best to just do `List.contains`;
I went with `Iterable` to make sure I didn't break anything... I feel like in
practice the read set will be small as its 1 node per non-overlapping range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
