iamaleksey commented on code in PR #2982:
URL: https://github.com/apache/cassandra/pull/2982#discussion_r1450550936
##########
src/java/org/apache/cassandra/service/accord/AccordJournal.java:
##########
@@ -211,21 +254,28 @@ public Object shutdownNow()
@Override
public boolean awaitTermination(long timeout, TimeUnit units) throws
InterruptedException
{
- // TODO (expected)
+ // TODO (expected, other)
return true;
}
- void appendAuxiliaryRecord(AuxiliaryRecord record)
+ void appendAuxiliaryRecord(AuxiliaryRecord record, Object context)
{
Key key = new Key(record.timestamp, record.type());
- journal.write(key, record, SENTINEL_HOSTS);
+ journal.asyncWrite(key, record, SENTINEL_HOSTS, context);
}
- public void appendMessage(Message message, Executor executor,
AsyncWriteCallback callback)
+ public void appendRemoteRequest(Request request, ResponseContext context)
{
- Type type = Type.fromMessageType(message.type());
- Key key = new Key(type.txnId(message), type);
- journal.asyncWrite(key, message, SENTINEL_HOSTS, executor, callback);
+ Type type = Type.fromMessageType(request.type());
+ Key key = new Key(type.txnId(request), type);
+ journal.asyncWrite(key, request, SENTINEL_HOSTS, context);
+ }
+
+ public void appendLocalRequest(LocalRequest<?> request)
Review Comment:
Addressed, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
