JeetKunDoug commented on code in PR #3046:
URL: https://github.com/apache/cassandra/pull/3046#discussion_r1453785602
##########
src/java/org/apache/cassandra/io/sstable/CQLSSTableWriter.java:
##########
@@ -614,6 +655,19 @@ public Builder withBuildIndexes(boolean buildIndexes)
return this;
}
+ /**
+ * Whether the underlying schema which was created for the purpose of
the generation should be
+ * removed when the writing is finished. Defaults to true and should
not be changed under normal circumstances.
+ *
+ * @param removeSchemaAfterDone true if underlying schema will be
removed, false otherwise.
+ * @return this builder
+ */
+ public Builder removeSchemaAfterDone(boolean removeSchemaAfterDone)
Review Comment:
Remember that the builder is a public interface for consumers outside of the
C* code tree... this should stay public even if it's only used by tests in C*'s
repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
