frankgh commented on code in PR #2969:
URL: https://github.com/apache/cassandra/pull/2969#discussion_r1457788430
##########
src/java/org/apache/cassandra/transport/messages/StartupMessage.java:
##########
@@ -118,8 +121,34 @@ else if (compression.equals("lz4"))
clientState.setDriverVersion(options.get(DRIVER_VERSION));
}
- if (DatabaseDescriptor.getAuthenticator().requireAuthentication())
+ IAuthenticator authenticator = DatabaseDescriptor.getAuthenticator();
+ if (authenticator.requireAuthentication())
+ {
+ // If the authenticator supports early certificate authentication,
attempt to authenticate with certificates.
+ if (authenticator.supportsEarlyCertificateAuthentication())
Review Comment:
in the mtls with password auth fallback, we could also authenticate here if
client certs are presented . I'm thinking the API could be a bit more generic,
thinking of supporting other types of early authentication .
```
if
(authenticator.supportsEarlyAuthentication(someContextThatHelpsMakingTheDetermination))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
