maedhroz commented on code in PR #2935:
URL: https://github.com/apache/cassandra/pull/2935#discussion_r1463818965
##########
src/java/org/apache/cassandra/index/sai/StorageAttachedIndex.java:
##########
@@ -493,8 +493,7 @@ public long getEstimatedResultRows()
@Override
public boolean isQueryable(Status status)
{
- // consider unknown status as queryable, because gossip may not be
up-to-date for newly joining nodes.
- return status == Status.BUILD_SUCCEEDED || status == Status.UNKNOWN;
+ return status == Status.BUILD_SUCCEEDED;
Review Comment:
I think the consensus from some discussion on ASF Slack is that we can still
attempt queries against UNKNOWN replicas, but only if there aren't enough
BUILD_SUCCEEDED replicas present.
CC @jasonstack @pkolaczk @JeremiahDJordan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
