beobal commented on code in PR #3040:
URL: https://github.com/apache/cassandra/pull/3040#discussion_r1466363757
##########
src/java/org/apache/cassandra/locator/SimpleStrategy.java:
##########
@@ -158,13 +161,4 @@ public Collection<String>
recognizedOptions(ClusterMetadata metadata)
{
return Collections.singleton(REPLICATION_FACTOR);
}
-
- protected static void prepareOptions(Map<String, String> options,
Map<String, String> previousOptions)
Review Comment:
This shouldn't be removed. It's only invoked by reflection (in
`AbstractReplicationStrategy::prepareReplicationStrategyOptions`) so it appears
unused. Restoring it fixes the 6 failing unit tests in the CI results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
