smiklosovic commented on code in PR #3085:
URL: https://github.com/apache/cassandra/pull/3085#discussion_r1478692511
##########
src/java/org/apache/cassandra/auth/MutualTlsWithPasswordFallbackAuthenticator.java:
##########
@@ -34,6 +37,9 @@
public class MutualTlsWithPasswordFallbackAuthenticator extends
PasswordAuthenticator
{
private final MutualTlsAuthenticator mutualTlsAuthenticator;
+
+ private static final Set<String> MODES =
Sets.newHashSet(PasswordAuthenticator.MODE, MutualTlsAuthenticator.MODE);
Review Comment:
I am just wondering ... why are we referencing these String constants in
either authenticators? I think that the more "clean" approach would be to
return in `getSupportedAuthenticationModes` `PasswordAuthenticator.MODES` and
`MutualTlsAuthenticator.MODES`. In other words, we should create a new set by
combination of `MODES`. That way, when some `MODE` was added to these
authenticators, this one would already return them all without any need to do
add it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
