tolbertam commented on code in PR #3085:
URL: https://github.com/apache/cassandra/pull/3085#discussion_r1478719430
##########
src/java/org/apache/cassandra/auth/AuthenticatedUser.java:
##########
@@ -33,10 +35,10 @@
public class AuthenticatedUser
{
public static final String SYSTEM_USERNAME = "system";
- public static final AuthenticatedUser SYSTEM_USER = new
AuthenticatedUser(SYSTEM_USERNAME);
+ public static final AuthenticatedUser SYSTEM_USER = new
AuthenticatedUser(SYSTEM_USERNAME, SYSTEM_USERNAME);
Review Comment:
I had considered an Enum, but one thing I was mindful of was third party
`IAuthenticator` implementations. If they wanted to introduce their own mode
of auth, they would not be able to without making a change to the core codebase
since Enums are effectively final.
Is this something we should support? If not I'm fine with using an Enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
