smiklosovic commented on code in PR #3085:
URL: https://github.com/apache/cassandra/pull/3085#discussion_r1479356671


##########
src/java/org/apache/cassandra/auth/AuthenticatedUser.java:
##########
@@ -74,6 +105,24 @@ public RoleResource getPrimaryRole()
         return role;
     }
 
+    /**
+     * The mode of authentication used to authenticate this user, this will 
usually be
+     * some value of {@link AuthenticationMode#getDisplayName()} unless
+     * an implementor provides their own custom authentication scheme.
+     */
+    public String getAuthenticationMode()
+    {
+        return authenticationMode;

Review Comment:
   But on the other hand, I think I understand why you did it like this ... 
because 3rd party implementation with their own mode would not be in 
AuthenticationMode enum so they still need to find a way how to populate this 
with something custom.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to