blerer commented on code in PR #2300:
URL: https://github.com/apache/cassandra/pull/2300#discussion_r1479406657
##########
src/java/org/apache/cassandra/config/DatabaseDescriptor.java:
##########
@@ -521,20 +549,20 @@ else if (conf.disk_access_mode ==
Config.DiskAccessMode.mmap_index_only)
logger.warn("concurrent_replicates has been deprecated and should
be removed from cassandra.yaml");
if (conf.networking_cache_size == null)
- conf.networking_cache_size = new
DataStorageSpec.IntMebibytesBound(Math.min(128, (int)
(Runtime.getRuntime().maxMemory() / (16 * 1048576))));
+ conf.networking_cache_size = new
DataStorageSpec.IntMebibytesBound(Math.min(128, SPACE_UPPER_BOUND_MB));
if (conf.file_cache_size == null)
- conf.file_cache_size = new
DataStorageSpec.IntMebibytesBound(Math.min(512, (int)
(Runtime.getRuntime().maxMemory() / (4 * 1048576))));
+ conf.file_cache_size = new
DataStorageSpec.IntMebibytesBound(Math.min(512, SPACE_UPPER_BOUND_MB));
Review Comment:
The replaced value do not match the original value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
