smiklosovic commented on code in PR #3085:
URL: https://github.com/apache/cassandra/pull/3085#discussion_r1479412471
##########
src/java/org/apache/cassandra/auth/AuthenticatedUser.java:
##########
@@ -33,10 +35,10 @@
public class AuthenticatedUser
{
public static final String SYSTEM_USERNAME = "system";
- public static final AuthenticatedUser SYSTEM_USER = new
AuthenticatedUser(SYSTEM_USERNAME);
+ public static final AuthenticatedUser SYSTEM_USER = new
AuthenticatedUser(SYSTEM_USERNAME, SYSTEM_USERNAME);
Review Comment:
@tolbertam I think the approach 2) is a little bit superior here. The
reason I think so is that, as you said, CUSTOM is quite non-telling and it
would also mean that absolutely every other authentication mode, not part of
core Cassandra, would be CUSTOM ever. I don't like this. In
system_views.clients, it would be all "Custom", for JMX as well ... We can
definitely do better. It would make people question what actual authentication
mode that node is configured with if they do not see something explicit but
just "Custom". Like ... custom what? That is just not helpful.
I wanted to see how it would look like on a class so I implemented it here
https://github.com/tolbertam/cassandra/pull/1
It is just a commit on top of your latest stuff here, feel free to
cherry-pick that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
