tolbertam commented on code in PR #3085:
URL: https://github.com/apache/cassandra/pull/3085#discussion_r1481993726
##########
src/java/org/apache/cassandra/metrics/ClientMetrics.java:
##########
@@ -51,20 +93,50 @@ public final class ClientMetrics
private Meter protocolException;
private Meter unknownException;
+ private static final String AUTH_SUCCESS = "AuthSuccess";
+
+ private static final String AUTH_FAILURE = "AuthFailure";
+
+ private static final String CONNECTED_NATIVE_CLIENTS =
"ConnectedNativeClients";
+
private ClientMetrics()
{
}
+ /**
+ * @deprecated by {@link #markAuthSuccess(String)}
+ */
+ @Deprecated(since="5.1", forRemoval = true)
public void markAuthSuccess()
+ {
+ markAuthSuccess(null);
+ }
+
+ public void markAuthSuccess(String mode)
{
authSuccess.mark();
+ Optional.ofNullable(mode)
+ .flatMap((m) -> Optional.ofNullable(authSuccessByMode.get(m)))
+ .ifPresent(Meter::mark);
}
+ /**
+ * @deprecated by {@link #markAuthFailure(String)}
+ */
+ @Deprecated(since="5.1", forRemoval = true)
public void markAuthFailure()
{
authFailure.mark();
Review Comment:
good catch, this is definitely wrong, will fix it :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
