jakubzytka commented on code in PR #3107:
URL: https://github.com/apache/cassandra/pull/3107#discussion_r1490912308


##########
src/java/org/apache/cassandra/service/reads/ReadCallback.java:
##########
@@ -95,12 +93,15 @@ protected P replicaPlan()
         return replicaPlan.get();
     }
 
-    public boolean await(long timePastStart, TimeUnit unit)
+    /**
+     * await until the condition is signalled but not longer than 
timePastStart since startTimeNanos
+     */
+    public boolean awaitFrom(long startTimeNanos, long timePastStart, TimeUnit 
unit)

Review Comment:
   The original `await` name was confusing. It's typically associated with 
waiting a specified amount of time, which was not the case in the original code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to