dcapwell commented on code in PR #3108:
URL: https://github.com/apache/cassandra/pull/3108#discussion_r1491416592
##########
src/java/org/apache/cassandra/service/accord/AccordStateCache.java:
##########
@@ -141,36 +141,45 @@ private void maybeEvictSomeNodes()
while (iter.hasNext() && bytesCached > maxSizeInBytes)
{
AccordCachingState<?, ?> node = iter.next();
- checkState(node.references == 0);
-
- if (!node.canEvict())
- continue;
- /*
- * TODO (expected, efficiency):
- * can this be reworked so we're not skipping unevictable nodes
everytime we try to evict?
- */
- Status status = node.status(); // status() call completes (if
completeable)
Review Comment:
this is the bug that the JIRA talks about, this promotes `Saving` to
`Loaded`, and since we validate on evict this fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
