aweisberg commented on code in PR #3077:
URL: https://github.com/apache/cassandra/pull/3077#discussion_r1491611887
##########
src/java/org/apache/cassandra/cql3/statements/TransactionStatement.java:
##########
@@ -321,7 +326,8 @@ public Txn createTxn(ClientState state, QueryOptions
options)
List<TxnNamedRead> reads = createNamedReads(options, state,
ImmutableMap.of(), keySet::add);
Keys txnKeys = toKeys(keySet);
TxnRead read = createTxnRead(reads, txnKeys, null);
- return new Txn.InMemory(txnKeys, read, TxnQuery.ALL);
+ Txn.Kind kind = txnKeys.size() == 1 && getNonSerialWriteStrategy()
== accord ? EphemeralRead : Read;
Review Comment:
Minor, but this is a per key property that wouldn't require absolutely all
writes going through Accord. Would be nice to have the performance benefit
during migration, but maybe a TODO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
