smiklosovic commented on code in PR #3101: URL: https://github.com/apache/cassandra/pull/3101#discussion_r1495665306
########## src/java/org/apache/cassandra/tools/nodetool/clustermetadata/CMSCmdGroupHelp.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.cassandra.tools.nodetool.clustermetadata; + +import io.airlift.airline.Help; +import org.apache.cassandra.tools.INodeProbeFactory; +import org.apache.cassandra.tools.NodeTool; +import org.apache.cassandra.tools.Output; + +/** + * Help class for Cluster Metadata Service nodetool command group. + */ +public class CMSCmdGroupHelp extends Help implements NodeTool.NodeToolCmdRunnable Review Comment: This will print help when `nodetool cms` is executed as it just expects some other subcommand to be specified. This is not the same as for the case of repair_admin, when `nodetool repair_admin` is executed, it will default to `ListCmd`. We might theoretically default to "cms describe" if only `nodetool cms` is run. I think that having `nodetool cms` to default to `nodetool cms describe` is sensible to do so we might rewrite this as it is done for repair case. Having to write `nodetool cms describe` every single time instead of `nodetool cms` seems like a drag ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
