mike-tr-adamson commented on code in PR #3122:
URL: https://github.com/apache/cassandra/pull/3122#discussion_r1502573302
##########
src/java/org/apache/cassandra/index/sai/plan/QueryController.java:
##########
@@ -73,7 +73,7 @@ public class QueryController
private final ColumnFamilyStore cfs;
private final ReadCommand command;
private final QueryContext queryContext;
- private final TableQueryMetrics tableQueryMetrics;
+ public final TableQueryMetrics tableQueryMetrics;
Review Comment:
This is not a big deal but it seems that we could avoid this change if we
stored the `tableQueryMetrics` in the `StorageAttachedIndexSearcher` and make
`ResultRetriever` an inner class rather than a static inner class.
If we choose not to do that, can the `tableQueryMetrics`, at least, be
separated, so that the `public` and `private` members are separate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
