frankgh opened a new pull request, #105: URL: https://github.com/apache/cassandra-sidecar/pull/105
In this PR, we fix the race condition that occurs when determining the port number to use for the registry. Currently, the port is determined in the `availablePort` method, where a socket is determined by using port 0. The OS will assign a port number for the socket, but we immediately close the socket, and use the determined port number to run the test. This PR brings a better approach by directly using port 0 while creating the registry, thus avoiding the intermediate step and directly using the port that originally was assigned to the registry without releasing it until the end of the test. Additionally in this PR, we rename the integration test JmxClientTest which name is colliding with the unit test. This allows for a better IDE integration and debugging experience. Patch by Francisco Guerrero; Reviewed by TBD for CASSANDRASC-113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
