beobal commented on code in PR #3165:
URL: https://github.com/apache/cassandra/pull/3165#discussion_r1517847269
##########
test/distributed/org/apache/cassandra/distributed/test/log/BounceIndexRebuildTest.java:
##########
@@ -41,10 +41,12 @@ public void bounceTest() throws Exception
cluster.schemaChange(withKeyspace("create index idx on %s.tbl
(x)"));
Object[][] res =
cluster.coordinator(1).execute(withKeyspace("select * from %s.tbl where x=5"),
ConsistencyLevel.ALL);
assert res.length > 0;
+ final String pattern = "Index build of idx complete|Index
\\[idx\\] became queryable after successful build";
Review Comment:
It's been a while since I looked at this, so I had to code dive a bit to
understand why switching between legacy 2i and SAI would necessitate this
change. Would you be ok with adding a comment? Something along the lines of:
```
// Both SAI and legacy 2i indexes will log the "Index [idx] became
queryable..." message every time the index is
// initialised. Only legacy indexes may rebuild a previously built index, in
which case they log the "Index
// build of idx complete" message. So this is to verify that happens at most
once, implying that legacy
// 2i does not get rebuilt after a restart.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
