smiklosovic commented on code in PR #249:
URL: https://github.com/apache/cassandra-dtest/pull/249#discussion_r1522938965
##########
cqlsh_tests/test_cqlsh.py:
##########
@@ -1040,7 +1040,7 @@ def test_default_keyspaces_exist(self):
node1, = self.cluster.nodelist()
# Describe keyspaces
- expected_keyspaces = ['system_schema', 'system', 'system_traces',
'system_views',
+ expected_keyspaces = ['system_schema', 'system', 'system_traces',
'system_views', 'system_metrics',
Review Comment:
@Mmuzaf this will not work because system_metrics will be only on trunk and
this test will be executed for 4.0+ so when 4.0 will be built, this one will
not be there. You need to do it like below for system_cluster_metadata case:
if self.cluster.version() >= LooseVersion('5.1'):
expected_keyspaces.append('system_cluster_metadata')
expected_keyspaces.append('system_metrics')
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
