smiklosovic commented on code in PR #3180:
URL: https://github.com/apache/cassandra/pull/3180#discussion_r1530544132
##########
src/java/org/apache/cassandra/hints/HintsStore.java:
##########
@@ -76,9 +77,13 @@ private HintsStore(UUID hostId, File hintsDirectory,
ImmutableMap<String, Object
dispatchDequeue = new ConcurrentLinkedDeque<>(descriptors);
corruptedFiles = new ConcurrentLinkedQueue<>();
hintsExpirations = new ConcurrentHashMap<>();
+ hintsSizes = new ConcurrentHashMap<>();
//noinspection resource
lastUsedTimestamp = descriptors.stream().mapToLong(d ->
d.timestamp).max().orElse(0L);
+
+ for (HintsDescriptor descriptor : Iterables.concat(dispatchDequeue,
corruptedFiles))
Review Comment:
it is not technically necessary to iterate over corrputedFiles because they
are empty here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]